From 4470f281fcae64068d799fa4103a6c06d89b8c07 Mon Sep 17 00:00:00 2001
From: Maxime Augier <max@xolus.net>
Date: Tue, 13 Aug 2024 16:10:02 +0200
Subject: [PATCH] Skip logging of ping messages, cleanup

---
 src/observation.rs | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/observation.rs b/src/observation.rs
index 358fcb7..4d66667 100644
--- a/src/observation.rs
+++ b/src/observation.rs
@@ -1,4 +1,4 @@
-use serde::{de::IntoDeserializer, Deserialize};
+use serde::Deserialize;
 use serde_repr::Deserialize_repr;
 use std::num::{ParseFloatError, ParseIntError};
 use thiserror::Error;
@@ -6,7 +6,7 @@ use tracing::info;
 use ureq::json;
 
 use crate::{
-    api::{ChargerOpMode, Context, OutputPhase, UtcDateTime},
+    api::{ChargerOpMode, Context, UtcDateTime},
     signalr::{self, StreamError},
     stream::NegotiateError,
 };
@@ -90,6 +90,7 @@ impl ObservationData {
         })
     }
 
+    /*
     fn dynamic_type(&self) -> DataType {
         match self {
             ObservationData::Boolean(_) => DataType::Boolean,
@@ -98,6 +99,7 @@ impl ObservationData {
             ObservationData::String(_) => DataType::String,
         }
     }
+    */
 }
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
@@ -278,7 +280,8 @@ impl Stream {
         loop {
             let msg = self.inner.recv()?;
             match &msg {
-                Empty | Ping | InvocationResult { .. } => info!("Skipped message: {msg:?}"),
+                Ping => continue,
+                Empty | InvocationResult { .. } => info!("Skipped message: {msg:?}"),
                 Invocation { target, arguments } if target == "ProductUpdate" => {
                     if arguments.len() != 1 {
                         return de(msg);